Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the CRD's finalizer name #270

Open
4 tasks
terassyi opened this issue Jan 16, 2024 · 0 comments
Open
4 tasks

Rename the CRD's finalizer name #270

terassyi opened this issue Jan 16, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@terassyi
Copy link
Contributor

What

Rename finalizer from coil.cybozu.com to coil.cybozu.com/finalizer.

New coil's CRD can add finalizers that don't have /.
In the future, CRD's finalizers also will need to have /.

ref: kubernetes/kubernetes#119508

How

Coil adds the finalizer like following.

func (r *AddressPool) Default() {

We have to rename its name and migrate existing finalizers.

Checklist

  • Finish implentation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
@terassyi terassyi added the good first issue Good for newcomers label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant