Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmPy: Drop support #6458

Open
4 tasks
oliver-sanders opened this issue Nov 5, 2024 · 0 comments · May be fixed by #6476
Open
4 tasks

EmPy: Drop support #6458

oliver-sanders opened this issue Nov 5, 2024 · 0 comments · May be fixed by #6476
Assignees
Milestone

Comments

@oliver-sanders
Copy link
Member

Cylc has provided EmPy support for a few years, however, it has had very little uptake in that time.

  • EmPy support was provided at the request of a project which has since moved away from it.
  • Support has been broken since November 2023, however, this has gone unreported until recently.
  • It would appear that no Cylc users are making use of EmPy support (they can't be, it's broken).
  • Cylc-EmPy integration is poorly developed in contrast to Jinja2 support.
  • EmPy is a high risk dependency (single maintainer, no public source repo, intermittent release cycle).

As a result we have agreed to retire support (meeting 2024-11-04).

Cylc's preprocessor logic is fairly well abstracted (shebang to identify preprocessor, relatively simple to write a preprocessor module, Cylc&Rose both abstract template variable arguments from the preprocessor engine) so supporting other preprocessors remains possible, though probably something we would want to confine to a plugin rather than accepting into the core repository. We should aim to abstract the pre-processor interface to make this more pluggable in the future.

TODO:

  • Cylc Flow (remove references, add helpful error message)
  • Cylc Rose (remove references)
  • Docs (remove references)
  • Syntax files (we can remove references here, but don't need to).
@oliver-sanders oliver-sanders added the bug Something is wrong :( label Nov 5, 2024
@oliver-sanders oliver-sanders added this to the 8.4.0 milestone Nov 5, 2024
@oliver-sanders oliver-sanders self-assigned this Nov 13, 2024
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Nov 13, 2024
* Closes cylc#6458
* EmPy support is currently broken.
* As there are no users of this integration and concerns over
  the future of the package, we have decided to drop support
  rather than fixing it.
@oliver-sanders oliver-sanders linked a pull request Nov 13, 2024 that will close this issue
8 tasks
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Nov 13, 2024
* Closes cylc#6458
* EmPy support is currently broken.
* As there are no users of this integration and concerns over
  the future of the package, we have decided to drop support
  rather than fixing it.
oliver-sanders added a commit to oliver-sanders/cylc-doc that referenced this issue Nov 13, 2024
@MetRonnie MetRonnie added dependencies and removed bug Something is wrong :( labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants