docs: add example to expand the usage of the get method #5469
Conversation
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
|
|
You will need to run linting, as prettier does not accept the semicolon. |
| @@ -143,6 +143,12 @@ cy.get('form').within(() => { | |||
| }) | |||
| ``` | |||
|
|
|||
| #### Find an anchor element by its label/text, remove some attribute and click it | |||
|
|
|||
There was a problem hiding this comment.
It would be good to an add explanation of why this is useful. Something like:
| The following may be useful to change remove a `target` of `"_blank"` before clicking a link that would otherwise launch a new tab/window: | |
| #### Find an anchor element by its label/text, remove some attribute and click it | ||
|
|
||
| ```javascript | ||
| cy.get('a', { name: 'My link text' }).invoke('removeAttr', 'target').click(); |
There was a problem hiding this comment.
The syntax here is not correct - it looks like a mix of Cypress and Testing Library syntax, the following would work though:
| cy.get('a', { name: 'My link text' }).invoke('removeAttr', 'target').click(); | |
| cy.contains('a', 'hello').invoke('removeAttr', 'target').click(); |
There was a problem hiding this comment.
If the example is changed from cy.get() to cy.contains(), would it then need to be added to https://github.com/cypress-io/cypress-documentation/blob/main/docs/api/queries/contains.mdx instead?
|
@hlawuleka Thanks for the contribution! Could you please sign our CLA? Also can you address the feedback? Otherwise we'll need to close this PR. |
|
@hlawuleka We haven't heard anything from you, so we are closing this PR. If you have time to take another look, please re-open with the provided feedback addressed! |
No description provided.