docs(selectFile): readFile & fixture should use null instead of { encoding: null }
#5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`null` should not wrapped in the `{ encoding: null }`, which would cause a type error.
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
|
ronny1020
changed the title
null instead of { encoding: null }null instead of { encoding: null }
ronny1020
changed the title
null instead of { encoding: null }null instead of { encoding: null }
ronny1020
changed the title
null instead of { encoding: null }null instead of { encoding: null }
emilyrohrbough
approved these changes
Nov 16, 2023
|
@ronny1020 nice catch! thank you! 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nullshould not wrapped in the{ encoding: null }, which would cause a type error.reference: https://docs.cypress.io/api/commands/fixture#Syntax