-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation design with cypress design system #5572
Conversation
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a few changes to fix wonky content. There are still a few area that could use attention tho.
- this was a quick visual to help try to describe the branch review UI, but it looks like the MDX version bump changed how nested lists render. it may be worth cooking up something better vs. trying to wrestle this into place https://share.cleanshot.com/6Y3Q0bLN
- some tags are wrapped in a
<p>
if they have accompanying text and some don't. Ends up creating inconsistent spacing, sometimes across the same page https://share.cleanshot.com/Wj1fwCRg - not sure if the design treatment changed, but seems like some admonition line height is more compressed than the figma https://share.cleanshot.com/7qyQ2gjJ (the color shouldn't change, just pointing out the whitespace)
src/css/markdown.scss
Outdated
@@ -4,15 +4,15 @@ div.markdown { | |||
|
|||
ul { | |||
padding-left: var(--ifm-list-left-padding); | |||
li { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, we'll still want the disc when a it's first child and circle when indented further.
This way not all bullets become circles like we have with this change as is:
https://share.cleanshot.com/3Mk98nzB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, missed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed here d2ce38e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR leaves
|
Actually we should only have a package-lock here. The yarn.lock is superfluous... |
If |
Update the documentation template to match Cypress Brand