-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few guides to UI Coverage #6063
Conversation
cypress-documentation Run #261
Run Properties:
|
Project |
cypress-documentation
|
Branch Review |
uicov-guides
|
Run status |
Passed #261
|
Run duration | 07m 16s |
Commit |
afcc1206ef: Update docs/ui-coverage/guides/ignore-elements.mdx
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
297
|
View all changes introduced in this branch ↗︎ |
UI Coverage
10.96%
|
|
---|---|
Untested elements |
2357
|
Tested elements |
3
|
Accessibility
96.86%
|
|
---|---|
Failed rules |
0 critical
4 serious
4 moderate
0 minor
|
Failed elements |
438
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not completed review yet, will keep going, but a few things so far
@jennifer-shehane it looks like we're being inconsistent with the "paid addon" across the uicov docs... Currently the "paid addon" is in the "Introduction", and not in the subsequent docs... ...but then we use a totally different "paid addon" banner for pages like:
Examples |
@brian-mann Yes, there is not a consistent design decision on how to show this on pages beyond the Get Started pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully grok the structure of the "Why use X" and then "Common use cases" – there's nothing else under the "Why use X" so do there have to be these double headings?
Co-authored-by: Peter Stakoun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still inconsistencies, but I think it's good enough to merge and iterate since it's blocking other things.
Adding guides on common use cases so we can feature them on the intro page.