Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cy.writeFile should resolve to null #2466

Closed
lilaconlee opened this issue Sep 12, 2018 · 2 comments
Closed

cy.writeFile should resolve to null #2466

lilaconlee opened this issue Sep 12, 2018 · 2 comments
Assignees
@lilaconlee
Labels
type: breaking change Requires a new major release version

Comments

@lilaconlee
Copy link
Contributor

Currently, cy.writeFile return the contents written to the file, which is not the same behavior as fs. In the case of appends, it yields only what was appended and not the entire file.

It should return null, to align with libraries with similar functionality.
@lilaconlee lilaconlee added the type: breaking change Requires a new major release version label Sep 12, 2018
@lilaconlee lilaconlee added this to the 4.0.0 milestone Sep 12, 2018
@lilaconlee lilaconlee self-assigned this Nov 6, 2018
This was referenced Nov 6, 2018
Merged
Closed
@jennifer-shehane jennifer-shehane removed this from the 4.0.0 milestone Nov 13, 2018
@chrisbreiding chrisbreiding mentioned this issue Nov 26, 2018
Closed
31 tasks
chrisbreiding pushed a commit that referenced this issue Dec 3, 2018
@lilaconlee @chrisbreiding
Yield null from cy.writeFile (#2731)
e929086 
- Fixes #2466 
- [Docs PR](cypress-io/cypress-documentation#1117)

Should be part of 4.0.0
@chrisbreiding
Copy link
Contributor

The code for this is complete but has not yet been released. It will be released in 4.0.

@chrisbreiding chrisbreiding mentioned this issue May 21, 2019
Closed
18 tasks
chrisbreiding pushed a commit that referenced this issue May 21, 2019
@lilaconlee @chrisbreiding
Yield null from cy.writeFile (#2731)
ce8f0ee 
- Fixes #2466 
- [Docs PR](cypress-io/cypress-documentation#1117)

Should be part of 4.0.0
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 6, 2020

Released in 4.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lilaconlee lilaconlee

Labels
type: breaking change Requires a new major release version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisbreiding @jennifer-shehane @lilaconlee