Mocha's afterEach is missing "this"

[cbromberg]

Current behavior:

In mocha it's documented behaviour that you can access this, which in turn gives access to currentTest. See Mocha.IBeforeAndAfterContext; just like in beforeEach.

With Cypress intercepting this and inserting the screenshooter there, it misses to pass on the this project, here's the code I found in the debugger:

_afterEach(name, function () {
    onFailed.call(this)
    fn()
})

where fn is the user-defined afterEach function

Desired behavior:

this should be passed on. fn.call(this) would achieve that (in the context of the code above).

Steps to reproduce: (app code and test code)

context('Mocha afterEach', () => {
    beforeEach(function() {
        expect(this).to.be.not.undefined
        expect(this).to.have.property('currentTest')
    })

    afterEach(function() {
        expect(this).to.be.not.undefined
        expect(this).to.have.property('currentTest')
    })

    it('This', () => {
        expect(this).to.be.not.undefined
        expect(this).to.have.property('test')
    })
})

Versions

Cypress 3.2.0

[Lakitna]

This might be because Cypress 3.x is using an old version of Mocha (3.5.3 where latest = 6.1.1). This has been upgraded in the 4.0 branch.

Edit: It has been upgraded to Mocha 5.x

[jennifer-shehane]

Closing this as duplicate of #2528 @chrisbreiding Can you verify this will be fixed with Mocha upgrade?

[jennifer-shehane]

This is no longer undefined after the Mocha upgrade, but there is a circular reference error thrown when used in this way.

TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Test'
    |     property 'commands' -> object with constructor 'Array'
    |     index 0 -> object with constructor 'Object'
    |     property 'actual' -> object with constructor 'Context'
    --- property 'currentTest' closes the circle

Because this error occurred during a 'after each' hook we are skipping the remaining tests in the current suite: 'Mocha afterEach'

spec.js

context('Mocha afterEach', () => {
  beforeEach(function () {
    expect(this).to.be.not.undefined
    expect(this).to.have.property('currentTest')
  })

  afterEach(function () {
    expect(this).to.be.not.undefined
    expect(this).to.have.property('currentTest')
  })

  it('This', () => {
    expect(this).to.be.not.undefined
    expect(this).to.have.property('test')
  })
})

3.8.3

4.0.0

[cypress-app-bot]

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

[cypress-app-bot]

This issue has been closed due to inactivity.