From e3d39f52ee76b3d5689635dff437ce00a8723af3 Mon Sep 17 00:00:00 2001
From: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Date: Mon, 20 Nov 2023 20:40:19 +0000
Subject: [PATCH] test: fix example-recording failure reporting status (#1073)

---
 .github/workflows/example-recording.yml | 4 +---
 README.md                               | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/example-recording.yml b/.github/workflows/example-recording.yml
index eb609ef05..aec0ac0c1 100644
--- a/.github/workflows/example-recording.yml
+++ b/.github/workflows/example-recording.yml
@@ -55,9 +55,6 @@ jobs:
         # let's give this action an ID so we can refer
         # to its output values later
         id: cypress
-        # Continue the build in case of an error, as we need to set the
-        # commit status in the next step, both in case of success and failure
-        continue-on-error: true
         with:
           working-directory: examples/recording
           record: true
@@ -69,6 +66,7 @@ jobs:
       # https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#steps-context
       # "output" can be success, failure, cancelled, or skipped
       - name: Print Cypress Cloud URL
+        if: always()
         run: |
           echo Cypress finished with: ${{ steps.cypress.outcome }}
           echo See results at ${{ steps.cypress.outputs.resultsUrl }}
diff --git a/README.md b/README.md
index 56398d04d..a1f8a37ee 100644
--- a/README.md
+++ b/README.md
@@ -1370,14 +1370,12 @@ This is an example of using the step output `resultsUrl`:
   # let's give this action an ID so we can refer
   # to its output values later
   id: cypress
-  # Continue the build in case of an error, as we need to set the
-  # commit status in the next step, both in case of success or failure
-  continue-on-error: true
   with:
     record: true
   env:
     CYPRESS_RECORD_KEY: ${{ secrets.RECORDING_KEY }}
 - name: Print Cypress Cloud URL
+  if: always()
   run: |
     echo Cypress finished with: ${{ steps.cypress.outcome }}
     echo See results at ${{ steps.cypress.outputs.resultsUrl }}