Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karma is not used... and browserify is only used from karma. #18

Open
JJ opened this issue Dec 4, 2021 · 0 comments
Open

karma is not used... and browserify is only used from karma. #18

JJ opened this issue Dec 4, 2021 · 0 comments

Comments

@JJ
Copy link

JJ commented Dec 4, 2021

Summary

karma is a web server generally used for tests, and it's included along with a series of helpers. However, it does not seem to be really used. It's not invoked from any script. Browser tests seem to be skipped.

Simplest Example to Reproduce

Run git grep "karma start" for instance. There might be other ways of checking it, but unless it's used internally (or was used), I don't see how it's checked nowadays.

Expected Behavior

It should be used, possibly for browser tests. It does not seem to have been substituted by anything else.

Current Behavior

npm run test-browser just skips the test.

Possible Solution

Eliminate karma and all browser tests, since they don't seem to be used at all. Alternatively, get it back to work...

Context

karma* introduce several vulnerabilities, and they're simply dead code, apparently. If it's not used, it's best to eliminate it.

@JJ JJ changed the title karma is not used karma is not used... and browserify is only used from karma. Dec 4, 2021
stusmall added a commit to stusmall/request that referenced this issue Oct 4, 2023
stusmall added a commit to stusmall/request that referenced this issue Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant