You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
karma is a web server generally used for tests, and it's included along with a series of helpers. However, it does not seem to be really used. It's not invoked from any script. Browser tests seem to be skipped.
Simplest Example to Reproduce
Run git grep "karma start" for instance. There might be other ways of checking it, but unless it's used internally (or was used), I don't see how it's checked nowadays.
Expected Behavior
It should be used, possibly for browser tests. It does not seem to have been substituted by anything else.
Current Behavior
npm run test-browser just skips the test.
Possible Solution
Eliminate karma and all browser tests, since they don't seem to be used at all. Alternatively, get it back to work...
Context
karma* introduce several vulnerabilities, and they're simply dead code, apparently. If it's not used, it's best to eliminate it.
The text was updated successfully, but these errors were encountered:
JJ
changed the title
karma is not usedkarma is not used... and browserify is only used from karma.
Dec 4, 2021
stusmall
added a commit
to stusmall/request
that referenced
this issue
Oct 4, 2023
Summary
karma
is a web server generally used for tests, and it's included along with a series of helpers. However, it does not seem to be really used. It's not invoked from any script. Browser tests seem to be skipped.Simplest Example to Reproduce
Run
git grep "karma start"
for instance. There might be other ways of checking it, but unless it's used internally (or was used), I don't see how it's checked nowadays.Expected Behavior
It should be used, possibly for browser tests. It does not seem to have been substituted by anything else.
Current Behavior
npm run test-browser
just skips the test.Possible Solution
Eliminate
karma
and all browser tests, since they don't seem to be used at all. Alternatively, get it back to work...Context
karma*
introduce several vulnerabilities, and they're simply dead code, apparently. If it's not used, it's best to eliminate it.The text was updated successfully, but these errors were encountered: