Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some WhatsApp chats are duplicated in the search menu #294

Open
ricott1 opened this issue Sep 14, 2024 · 7 comments
Open

Some WhatsApp chats are duplicated in the search menu #294

ricott1 opened this issue Sep 14, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@ricott1
Copy link

ricott1 commented Sep 14, 2024

Description:

Some Whatsapp chats are duplicated in the ˆn search menu and indistinguishable from each other (see Screenshot). When opened, only one of them contains the messages, while the other are just empty. Maybe this has something to do with changing number.

The problem is only for WhatsApp (at least for me).

Screenshot 2024-09-14 at 10 00 51

How to reproduce it:

Try to search for a WhatsApp chat. Not all of them display this behaviour.

Environment:

  • Version:
  • OS / distro: MacOS 13.2.1
@ricott1 ricott1 added the bug Something isn't working label Sep 14, 2024
@ricott1 ricott1 changed the title Some chats are duplicated in the search menu Some WhatsApp chats are duplicated in the search menu Sep 14, 2024
@d99kris
Copy link
Owner

d99kris commented Sep 14, 2024

Hi @ricott1 - thanks for reporting this. I don't see the issue on my side, but I've added some new developer mode debugging capability in nchat just now (in 4b1190b / v5.2.11). If you get a chance to build and run latest nchat, then please try start it in developer mode like this: nchat -m

Then when opening the ^n dialog, it will display chat ids (which in the case of WhatsApp are phone numbers) next to each contact name. It's maybe not a good idea to share the actual numbers here in public, but you could perhaps let me know if all numbers of this contact look like real (and unique) phone numbers, and whether they seem to support your theory about contact having changed phone numbers?

@Docbroke
Copy link

This issue occurs with telegram also, it affects chats with changed names. As far as I can see nchat somehow displays old chat names that no are longer in use.

@ricott1
Copy link
Author

ricott1 commented Sep 18, 2024

Hi @d99kris , thanks for picking this up. I built and ran in dev mode and indeed they look like real and unique phone numbers. I attach another screenshot (redacting the numbers ;) ). The same problem exists for other contacts, all of which (as far I as I can tell) display a different phone number. I don't have this problem with Telegram, but this could be just out of chance.

image

@d99kris
Copy link
Owner

d99kris commented Sep 21, 2024

Thanks for providing additional details, I have some idea what the issue is (basically nchat has a cache of contacts which is never pruned IIRC, contacts are only added). Will look into fixing this, but might take a little while. Meanwhile, if you're mainly using the contact list to navigate between existing chats (and not opening new chats), you can try the new goto chat function with key binding alt-n.

@ricott1
Copy link
Author

ricott1 commented Sep 23, 2024

Thanks! I really appreciate your time for this :)

@ricott1
Copy link
Author

ricott1 commented Sep 30, 2024

I was thinking, maybe a simpler workaround would be to allow to delete duplicate chats permanently on the UX? Maybe by persisting a list of filtered numbers that are just not shown. At least for me M-d does not work in achieving that.

@d99kris
Copy link
Owner

d99kris commented Sep 30, 2024

Thanks for the suggestion, yeah that should be a quicker (short-term) fix, will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants