Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pass prereq_os via add_plugin #16

Open
autarch opened this issue Jun 21, 2018 · 2 comments
Open

Cannot pass prereq_os via add_plugin #16

autarch opened this issue Jun 21, 2018 · 2 comments

Comments

@autarch
Copy link
Contributor

autarch commented Jun 21, 2018

I have this code that I'm running:

    $self->add_plugins(
        [
            'OSPrereqs' => {
                prereq_os                          => 'MSWin32',
                'DateTime::TimeZone::Local::Win32' => $version,
            }
        ],
    );

Even with the 0.011 release I still get this warning: "[=DTTZBundle/OSPrereqs] inferred OS name as =DTTZBundle/OSPrereqs, which looks like it came from a bundle!"

The problem, AFAICT, is that the BUILDARGS is doing some odd munging of the passed-in args. I think it's trying to filter out module names from everything else. It does handle plugin_name explicitly, but not prereq_os.

@autarch
Copy link
Contributor Author

autarch commented Oct 18, 2018

It'd be great if this could be fixed.

@Grinnz
Copy link

Grinnz commented Apr 18, 2019

It seems like the prereq_os option is broken in general - the plugin name is still used as the OS, and prereq_os gets added as a prereq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants