Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only supports one of Makefile.PL, Build.PL simultaneously #4

Open
karenetheridge opened this issue Jul 15, 2014 · 2 comments
Open

Only supports one of Makefile.PL, Build.PL simultaneously #4

karenetheridge opened this issue Jul 15, 2014 · 2 comments
Labels
bug

Comments

@karenetheridge
Copy link
Contributor

sometimes a dist has both! e.g. my default installer tool plugins in my plugin bundle are currently [MakeMaker::Fallback] and [ModuleBuildTiny::Fallback] :)

[AssertOS] is a nice tiny example of supporting both files at once.
@xdg xdg added the bug label Mar 1, 2016
@rivy rivy mentioned this issue Sep 9, 2016
Merged
@karenetheridge
Copy link
Contributor Author

Note this is not a bug I am experiencing personally, as Module::Build::Tiny doesn't support dynamic_config => 1, and I avoid Module::Build at all costs.

@karenetheridge
Copy link
Contributor Author

I think this is shipped now?

shlomif added a commit to shlomif/Dist-Zilla-Plugin-OSPrereqs that referenced this issue Mar 7, 2020
@shlomif
Munge both Makefile.PL and Build.PL if specified.
703da65 
dagolden#4

Thanks to @karenetheridge for the report.

----

I hereby disclaim any implicit or explicit ownership of my changes in this
changeset, and put them under a multiple licence consisting of your choice of
one of more of:

- The CC0 / Public Domain - https://creativecommons.org/choose/zero/ .

- The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License

- The default licence of your project

- The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version
2.1 or higher

- The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or
higher

- Any licence in the 2018-Aug-27 popular licenses list of
https://opensource.org/licenses

- The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later

- The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later

- The https://en.wikipedia.org/wiki/ISC_license

- The https://opensource.org/licenses/BSD-2-Clause

Crediting me will be nice, but not mandatory, and you can change the licence
of the project without needing my permission.
@shlomif shlomif mentioned this issue Mar 7, 2020
Open
clrpackages pushed a commit to clearlinux-pkgs/perl-Clipboard that referenced this issue Mar 10, 2020
@fenrus75
[update to 0.24] - convert "darwin" to a regex.
4365b48 
0.24    2020-03-07
    - Remove Makefile.PL due to ::OSPrereqs not munging it along with Build.PL
        - dagolden/Dist-Zilla-Plugin-OSPrereqs#4
    - Fix macOS detection.
        - shlomif/Clipboard#1
        - convert "darwin" to a regex.
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Sep 7, 2020
@0-wiz-0
p5-Clipboard: update to 0.26.
827c998 
0.26    2020-05-16

    - Try to fix 'Wide character in print' warning with Xclip
        - shlomif/Clipboard#4
        - Thanks to @shawnhcorey .

0.25    2020-05-14

    - Fix capitalization in GitHub links (the links still worked) in META.*
        - A minor and cosmetic change

0.24    2020-03-07

    - Remove Makefile.PL due to ::OSPrereqs not munging it along with Build.PL
        - dagolden/Dist-Zilla-Plugin-OSPrereqs#4
    - Fix macOS detection.
        - shlomif/Clipboard#1
        - convert "darwin" to a regex.

0.23    2020-03-06

    - Require deps on MacOS and MSwin32
        - See: shlomif/Clipboard#1
        - Thanks to https://metacpan.org/pod/Dist::Zilla::Plugin::OSPrereqs .

0.22    2020-01-28

    - Rebuild for order of 'NAME' and 'VERSION' sections in the generated
    POD documentation (see 0.001004 in
    https://metacpan.org/changes/distribution/Pod-Weaver-PluginBundle-SHLOMIF
    ).
        - VERSION used to appear before NAME.

0.21    2019-12-02

    - Min version of Mac::Pasteboard for macOS Catalina compat
        - Thanks to William H. Gilmore
gflohr added a commit to gflohr/AnyEvent-Filesys-Watcher that referenced this issue Jul 6, 2023
@gflohr
do not use Makefile
503348b 
Dist::Zilla::Plugin::OSPrereqs does not support os-specific dependencies
for both ExtUtils::MakeMaker and Module::Build simultaneously, see
dagolden/Dist-Zilla-Plugin-OSPrereqs#4.

Because I will sooner or later forget to apply the patch from
dagolden/Dist-Zilla-Plugin-OSPrereqs#17 to the
plug-in, it's better to remove the Makefile from the distribution
altogether for the time being.
@gflohr gflohr mentioned this issue Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karenetheridge @xdg