Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudMirror ThumbnailProvider doesn't provide thumbnails #6

Open
PrimalZed opened this issue Aug 27, 2024 · 2 comments
Open

CloudMirror ThumbnailProvider doesn't provide thumbnails #6

PrimalZed opened this issue Aug 27, 2024 · 2 comments

Comments

@PrimalZed
Copy link

PrimalZed commented Aug 27, 2024

The CloudMirror doesn't generate thumbnails using the ThumbnailProvider.

The Initialize method correctly gets called for each path, but the GetThumbnail doesn't seem to ever get called. Ultimately, the thumbnail does not load to the client.

image

I looked at #2, but that seems to be about the more general shell registration. The shell registration and registered handlers (or at least the custom command, I haven't tried the others) do work, including the call to ThumbnailProvider.Initialize.

C++ version

Running the latest from Windows-classic-samples gets thumbnails in the file explorer. (Oddly, breakpoints in GetThumbnail are not hit, and wprintf added to it does not show up in the console. I don't know whether that means it's actually getting the thumbnail in some other way, or that it's some threading change that runs the GetThumbnail method in some other context outside the debugger/console.)
image

@PrimalZed PrimalZed changed the title CloudMirror ThumbnailProvider incomplete CloudMirror ThumbnailProvider doesn't provide thumbnails Aug 27, 2024
@PrimalZed
Copy link
Author

A quick correction:
The windows-classic-samples c++ version does log from wprintf in the GetThumbnails. While it does not hit breakpoints, neither does it hit breakpoints in Initialize. There might be something about breakpoints with C++ that I'm not getting here.

@dahall
Copy link
Owner

dahall commented Sep 4, 2024

There are so many problems with that project conversion. Sorry. Personally, I would look to the ShellIconExtractor class if you need that support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@PrimalZed @dahall and others