Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have CapPlaneShaper conform more closely to WallMeshShaper #17

Open
GGAlanSmithee opened this issue Aug 23, 2024 · 4 comments
Open

Have CapPlaneShaper conform more closely to WallMeshShaper #17

GGAlanSmithee opened this issue Aug 23, 2024 · 4 comments

Comments

@GGAlanSmithee
Copy link
Contributor

Being able to use a CapPlaneShaper to create a dome ceiling on top of a WallMeshShaper would be super handy. It mostly works out-of-the-box but it seems there are some issues and/or edge-cases;

  1. it does not respect the walls height (screenshot 1)
  2. it does not always respect the walls rounding parameter (screenshot 2)
    2a. it does with certain values (screenshot 3)

PS. It would be great to be able to discuss things like this either in a Discord channel or i you enabled discussions here at Github, as to not create issues for things that might just be a user error.

image
image
image

@GGAlanSmithee
Copy link
Contributor Author

I actually think using a CapMoundShaper makes more sense in this case, as it produces a much more even shape, but the problem with the height offset still remains. Could be (probably is) a configuration error on my end.

20240823_123612.mp4

@GGAlanSmithee
Copy link
Contributor Author

GGAlanSmithee commented Aug 23, 2024

this could actually easily be solved by adding a height_offset parameter to the CapMoundShaper. This is basically a less than 10 lines of code change:

20240823_124757.mp4

@GGAlanSmithee
Copy link
Contributor Author

It would be amazing to have a RoofMeshShaper that would act like a combination of the CapMoundShaper and the WallMeshShaper, in the sense that it caps/forms like the former, but allows you to set a Mesh that would repeat, which would allow you to create something like shingles on a roof

image

@daleblackwood
Copy link
Owner

I've had a little bit of a go at this, the threading stuff is making it a bit hard to do due to the lack of a guaranteed build order. I'd have to (potentially) find a way to generate the wall mesh data independently for the cap, I need to somehow read the wall settings independently too.

My workaround for most scenes is just to modify the mesh I'm using to work better with independent caps, which isn't a solution but a workaround.

I'll leave this open for now, in case some brain-jolt occurs and I figure out a cheap, encapsulated way to process this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants