Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty lines are shown as whitespace error #14

Open
The-Compiler opened this issue Sep 9, 2020 · 2 comments
Open

Empty lines are shown as whitespace error #14

The-Compiler opened this issue Sep 9, 2020 · 2 comments

Comments

@The-Compiler
Copy link

It looks like with my setup at least (same as in #13 - Archlinux, emacs 27.1, Doom v2.0.9), diffs in the magit status buffer are indented by one space. This causes magit-delta to show empty lines as whitespace errors:

image

The same change in git diff with delta configured looks correct:

image

If I add (setq-default magit-delta-hide-plus-minus-markers nil) to my config, the issue persists:

image

If I remove (magit-delta-mode) from my config, it looks good (well, not as good as with delta!) as well:

image

@The-Compiler The-Compiler changed the title Empty lines are show as whitespace error Empty lines are shown as whitespace error Sep 9, 2020
@dandavison
Copy link
Owner

Hi @The-Compiler, thanks for this. It's been occurring for me too. Definitely needs looking into and I'll try to do that soon! If you do feel like digging in further, that would of course be fantastic (I do have other delta and magit-delta bugs to work on.)

@The-Compiler
Copy link
Author

I don't really speak Lisp and I'm busy with my own projects (mainly qutebrowser) - so I won't be able to help much I'm afraid. Take your time though, in the meantime I just configured the whitespace markers in a way they are a bit more subtle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants