Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No easy way to disable #28

Open
Atemu opened this issue Dec 3, 2023 · 1 comment
Open

No easy way to disable #28

Atemu opened this issue Dec 3, 2023 · 1 comment

Comments

@Atemu
Copy link

Atemu commented Dec 3, 2023

I needed to take a look at some line ending diffs and promptly ran into dandavison/delta#754 making it impossible to tell what's going on.

So as a workaround, I wanted to quickly disable magit-delta for the repo I was working on but I couldn't as it'd always re-enable itself in any new magit buffer (such as opening a diff).

This is due to the fact that it's enabled merely by adding a hook which are easy to work with as a user. I propose changing it to both a hook and a variable; the hook reading the variable to determine whether it should actually enable delta for this buffer. There should then be a global variable to disable magit-delta and perhaps a project-scoped one.

@dandavison
Copy link
Owner

Hi @Atemu, yes I see you're right. It's implemented as an Emacs minor mode and so in theory M-x magit-delta-mode should toggle it. But I see that it becomes reactivated. If you work on this, if possible, it would be good to bear in mind this PR, which I think might be touching the lines of code you are referring to: #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants