Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rudimentary end-to-end test for meditor and file browser from DLP #1760

Closed
yarikoptic opened this issue Nov 22, 2023 · 1 comment · Fixed by #1789
Closed

Add rudimentary end-to-end test for meditor and file browser from DLP #1760

yarikoptic opened this issue Nov 22, 2023 · 1 comment · Fixed by #1789
Assignees
Labels
enhancement New feature or request released This issue/pull request has been released. tests Add or improve existing tests

Comments

@yarikoptic
Copy link
Member

As we all failed to catch an obvious bug while reviewing #1706 and that required hotfix #1759 . Could be prevented with a basic test of opening file browser view. I looked at https://github.com/dandi/dandi-archive/tree/master/web/test/src/tests but didn't find any for meditor or file browser. Even if not thorough/sophisticated, I think such smoke tests could be already of notable value.

@yarikoptic yarikoptic added enhancement New feature or request tests Add or improve existing tests labels Nov 22, 2023
@dandibot
Copy link
Member

🚀 Issue was released in v0.3.72 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released This issue/pull request has been released. tests Add or improve existing tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants