Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable publish for dandisets without an asset summary #1812

Open
satra opened this issue Jan 15, 2024 · 2 comments
Open

disable publish for dandisets without an asset summary #1812

satra opened this issue Jan 15, 2024 · 2 comments
Labels
bug Something isn't working client/dlp Issues with the Dandiset Landing Page (DLP) client Pertains to the web client

Comments

@satra
Copy link
Member

satra commented Jan 15, 2024

@mvandenburgh and @jjnesbitt - as stated earlier in the thread, publish should be disabled for any dandiset that has an empty asset summary. i believe we should do a check on current dandisets. there are a few that fall into this situation. we don't want people hitting publish with no asset summary. that's going to break a bunch of expectations.

follow up from #1734

@satra satra added bug Something isn't working client Pertains to the web client client/dlp Issues with the Dandiset Landing Page (DLP) labels Jan 15, 2024
@jjnesbitt
Copy link
Member

Thanks for the issue. After #1803 and #1800 are merged, missing asset summaries should be a lot less common. Nonetheless, we can still follow up with a PR that prevents publish if it is still missing at the time of publish.

@satra
Copy link
Member Author

satra commented Jan 16, 2024

@jjnesbitt - hopefully that can be merged soon. in the meantime, can we run through dandisets and regenerate assets for those that are missing and say they are ready to publish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client/dlp Issues with the Dandiset Landing Page (DLP) client Pertains to the web client
Projects
None yet
Development

No branches or pull requests

2 participants