Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "open in browser" action in file browser view depending on mimetype #1848

Open
waxlamp opened this issue Jan 31, 2024 · 0 comments
Open
Labels
client Pertains to the web client enhancement New feature or request UX Affects usability of the system

Comments

@waxlamp
Copy link
Member

waxlamp commented Jan 31, 2024

An asset that does not have a browser-compatible mimetype (e.g., NWB file) should not display the "open in new window" action icon. The action in this case will be to download the resource, which is already possible through the specific download icon.

This will require some discussion, as we would be infringing on services the browser has provided in a standard manner for a long time. Furthermore, we need to inspect the mimetype of the asset (which DANDI refers to as the "encoding format" which is stored in the asset metadata) to do this properly.

This issue stems from unresolved conversations in #1666.

@waxlamp waxlamp added enhancement New feature or request UX Affects usability of the system client Pertains to the web client labels Jan 31, 2024
This was referenced Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pertains to the web client enhancement New feature or request UX Affects usability of the system
Projects
None yet
Development

No branches or pull requests

1 participant