Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design a proper error slide for the response pane #127

Open
danirod opened this issue Feb 2, 2025 · 0 comments · May be fixed by #129
Open

Design a proper error slide for the response pane #127

danirod opened this issue Feb 2, 2025 · 0 comments · May be fixed by #129
Labels
Bug Report that something does not work properly.

Comments

@danirod
Copy link
Owner

danirod commented Feb 2, 2025

In case of error, currently Cartero shows a little toast at the bottom of the screen which just prints the debug message of the underlying Error.

A slide to display error messages should be created and added to the response pane stack. It should be similar to the one that is visible when a request is firstly created or opened but not sent yet:

Image

This slide should be made visible when there is an error and should have the following components:

  • A proper error icon (maybe an X?)
  • The error message, and I mean the REAL error Message.
    • Stop with anyhow
      • Error messages are not translated using gettext, which is a bug.
      • It promotes a culture of not taking responsibility of the error.
    • If the error pane receives a CarteroError that is actually one of a subkind, it should always unwrap the real error message.
      • Instead of HTTP request error => extract the inner request error and use it.
      • If the error comes from glib, open it and get the error message using the glib API.
@danirod danirod added the Bug Report that something does not work properly. label Feb 2, 2025
@danirod danirod linked a pull request Feb 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report that something does not work properly.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant