Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete replay when upload was successful #119

Open
abma opened this issue Dec 28, 2019 · 3 comments
Open

delete replay when upload was successful #119

abma opened this issue Dec 28, 2019 · 3 comments

Comments

@abma
Copy link
Collaborator

abma commented Dec 28, 2019

IMHO there is no need to keep replays local.

i'm not sure: should this be part of the upload or spads?

@dansan
Copy link
Owner

dansan commented Jan 17, 2020

The idea was to allow downloading replays to watch them.
The oldest x files are deleted to conserve disk space.
Maybe it should be set to delete everything older than 1 week.

i'm not sure: should this be part of the upload or spads?
I think it should be the responsibility of the replay site to keep/delete replay files.
spads does not have public file serving capabilities.

@abma
Copy link
Collaborator Author

abma commented Jan 17, 2020

sorry, it was a bit confusing.

what i meant is: "replay_upload.py" should delete the replay after uploading it to replays.springrts.com.

so: where can replay_upload.py be found? i thought its in this repository?!

@dansan
Copy link
Owner

dansan commented Jan 25, 2020

what i meant is: "replay_upload.py" should delete the replay after uploading it to replays.springrts.com.
Oh… yes - that's make sense for autohosts. IMHO not so much for individuals.
I propose to add a cmdline switch to enable source file deletion, keeping the previous behavior for backwards compatibility - to not surprise admin.
so: where can replay_upload.py be found? i thought its in this repository?!
It's in the srs directory (don't know why…): https://github.com/dansan/spring-replay-site/blob/master/srs/replay_upload.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants