ipfs connection to local or embedded node #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallback to embedded if local doesn't work add buffer webpack plugin
nmushegian
reviewed
Apr 16, 2022
view/app.js
Outdated
| apiAddress: '/ip4/127.0.0.1/tcp/5001' | ||
| }), | ||
| jsIpfs({ | ||
| loadJsIpfsModule: () => require('ipfs-core'), |
There was a problem hiding this comment.
This is probably going to be overkill
Instead we probably want to just give the user a box to put their own rpc endpoint to use if they can't use one of a small set of default gateways
The important thing is to make sure the client actually verifies the CIDs when it grabs files from somewhere
add verification of ipfs content can input local node address remove ipfs-core and ipfs-provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no simple way of connecting to a browsers IPFS interface, it was removed ipfs/ipfs-companion#777 and not replaced.
This change makes it easy for anyone to use the app. It should just work without resorting to a gateway or requiring users to manually set up a node and set correct access control config. If they have a local node running configured for CORS it will use that, and otherwise create a core js-ipfs node in page.