Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from FluentAssertions #1450

Closed
WhitWaldo opened this issue Jan 18, 2025 · 2 comments
Closed

Migrate from FluentAssertions #1450

WhitWaldo opened this issue Jan 18, 2025 · 2 comments
Assignees
Labels
area/test dependencies Pull requests that update a dependency file technical debt
Milestone

Comments

@WhitWaldo
Copy link
Contributor

WhitWaldo commented Jan 18, 2025

Despite being Apache licensed for a long time, the author of the FluentAssertions library has elected to make a shift to a commercial license starting with v8

We're currently using version 5 of FluentAssertions across this SDK, but it's time to migrate to another tool.

Several users on that thread suggested switching to Shouldly and it's my understanding that our Apache license is compatible with the 3-clause BSD license they use. The syntax looks similar and should be a relatively easy migration.

Another alternative is switching to a fork of FluentAssertions before the license change, now hosted at AwesomeAssertions. This would mean we don't have to make any immediate code changes, but the README does state that one shouldn't expect updates to the fork, so we'd potentially be putting off a migration to another project in the future anyway.

I have a completed PR here to migrate to Shouldly, but wanted to open up the floor to any other suggestions.

@WhitWaldo WhitWaldo added area/test technical debt dependencies Pull requests that update a dependency file labels Jan 18, 2025
@WhitWaldo WhitWaldo added this to the v1.16 milestone Jan 18, 2025
@jcfnomada
Copy link

Please consider again https://github.com/AwesomeAssertions/AwesomeAssertions. There are a lot of old a recent contributers already in the project, so it is expected to continue it's work with bug fixes and new features.

@WhitWaldo
Copy link
Contributor Author

Please consider again https://github.com/AwesomeAssertions/AwesomeAssertions. There are a lot of old a recent contributers already in the project, so it is expected to continue it's work with bug fixes and new features.

I'll certainly keep an eye on what they're doing over here. The Shouldly PR is a hedge against that not working out.

@WhitWaldo WhitWaldo self-assigned this Jan 30, 2025
@WhitWaldo WhitWaldo modified the milestones: v1.16, v1.15 Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test dependencies Pull requests that update a dependency file technical debt
Projects
None yet
Development

No branches or pull requests

2 participants