removing maven resources plugin dependency from SDK #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artursouza the failure in the test doesn't seem related at all with the dependency that I removed: https://github.com/dapr/java-sdk/actions/runs/12806521307/job/35705160939?pr=1193 |
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
artursouza
changed the title
artursouza
approved these changes
Jan 19, 2025
artursouza
added a commit
to artursouza/java-sdk
that referenced
this pull request
Jan 19, 2025
* removing maven resources plugin dependency from SDK Signed-off-by: salaboy <[email protected]> * Update pom.xml Signed-off-by: salaboy <[email protected]> * adding maven resources plugin as a plugin Signed-off-by: salaboy <[email protected]> * Self-validate presence of sdk_version. Signed-off-by: Artur Souza <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Artur Souza <[email protected]> Co-authored-by: Artur Souza <[email protected]>
artursouza
added a commit
that referenced
this pull request
Jan 21, 2025
* removing maven resources plugin dependency from SDK * Update pom.xml * adding maven resources plugin as a plugin * Self-validate presence of sdk_version. --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Artur Souza <[email protected]> Co-authored-by: salaboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking why we need to have a maven plugin as a direct dependency of the SDK
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: