Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActorRuntime doesn't allow overriding ports similarly to WorkflowRuntimeBuilder or DaprClient #1202

Open
artur-ciocanu opened this issue Jan 31, 2025 · 1 comment · May be fixed by #1203
Open
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@artur-ciocanu
Copy link
Contributor

Expected Behavior

Awhile ago we have added support for properties override, this proved to be extremely useful and allowed us to remove a lot of global side effects based on System.setProperty() however the migration hasn't been complete. It seems that ActorRuntime doesn't allow us to override the Dapr ports, this leads to issues when running actors in Testcontainers.

When running in Testcontainers we always try to connect to default GRPC port and everything fails with GRPC exceptions.

We should change the ActorRuntime so we could override properties that could be populated from Testcontainers.

Actual Behavior

There is no way to override the ports when instantiating ActorRuntime.

Steps to Reproduce the Problem

A good description of the issue can be found in this PR: #1192

Release Note

RELEASE NOTE:

@artur-ciocanu artur-ciocanu added the kind/bug Something isn't working label Jan 31, 2025
@artur-ciocanu
Copy link
Contributor Author

@salaboy I have found the issue with Testcontainers, please check the issue. I will open a PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants