From e96fbdbf1135a9e41ef66eb23e6c35f41e0e05b7 Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 12 Sep 2023 10:09:59 +0200 Subject: [PATCH] Try a fix for the health check socket issues (#164) --- pkgs/firehose/lib/src/health/coverage.dart | 4 ++-- pkgs/firehose/lib/src/health/health.dart | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/firehose/lib/src/health/coverage.dart b/pkgs/firehose/lib/src/health/coverage.dart index 4e0e4d30..8fdbff2d 100644 --- a/pkgs/firehose/lib/src/health/coverage.dart +++ b/pkgs/firehose/lib/src/health/coverage.dart @@ -17,8 +17,8 @@ class Coverage { Coverage(this.coverageWeb); - Future compareCoverages() async { - var files = await Github().listFilesForPR(); + Future compareCoverages(Github github) async { + var files = await github.listFilesForPR(); var basePath = '../base_repo/'; return compareCoveragesFor(files, basePath); diff --git a/pkgs/firehose/lib/src/health/health.dart b/pkgs/firehose/lib/src/health/health.dart index 031ebe8a..a1e511ab 100644 --- a/pkgs/firehose/lib/src/health/health.dart +++ b/pkgs/firehose/lib/src/health/health.dart @@ -93,7 +93,7 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati } Future licenseCheck(Github github) async { - var files = await Github().listFilesForPR(); + var files = await github.listFilesForPR(); var allFilePaths = await getFilesWithoutLicenses(Directory.current); var groupedPaths = allFilePaths @@ -159,7 +159,7 @@ Changes to files need to be [accounted for](https://github.com/dart-lang/ecosyst Github github, bool coverageWeb, ) async { - var coverage = await Coverage(coverageWeb).compareCoverages(); + var coverage = await Coverage(coverageWeb).compareCoverages(github); var markdownResult = ''' | File | Coverage |