Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health bot - Package publish validation should list packages as publish_to: none #244

Open
dcharkes opened this issue Mar 22, 2024 · 1 comment

Comments

@dcharkes
Copy link

Currently the health bot package publish validation omits packages that have publish_to: none in their pubspec.

Maybe we should consider listing them? (E.g. we were confused by why the packages where not showing up.)

Possible downside: any example packages inside a package will start showing up as well. Can we somehow identify packages which are temporarily set to publish_to: none and ones which are meant to always stay publish_to: none? For example in mono repos all packages in pkgs/xxx should be published but packages in pkgs/xxx/example not. But that feels fragile.

cc @mosuem

@mosuem
Copy link
Member

mosuem commented Aug 20, 2024

We have the ignore_packages glob, which could be set to ignore anything beneath an example/ folder by default, and then remove the special-casing of publish_to: none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants