Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty string for "warn_on" causes failure #303

Open
jakemac53 opened this issue Oct 2, 2024 · 1 comment
Open

Empty string for "warn_on" causes failure #303

jakemac53 opened this issue Oct 2, 2024 · 1 comment
Labels
package:firehose type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jakemac53
Copy link
Contributor

If you do warn_on: "", then the job fails with FormatException: "--ignore_license" is not an allowed value for option "warn_on"..

Presumably, it ends up passing --warn_on --ignore_license with nothing between since the string is empty. The argument shouldn't be passed at all or something probably.

@jakemac53 jakemac53 added package:firehose type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Oct 2, 2024
@jakemac53
Copy link
Contributor Author

Fwiw, in general it is difficult to just move a job from default warning to default failure. You have to override the entire setting, with all the default failure jobs, and also override the warn_on settings to remove the job from that, but leave the old ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

1 participant