[CP] [ Service ] Include drive letter in path when launching DDS snapshot #55386
Assignees
Labels
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
cherry-pick-approved
Label for approved cherrypick request
cherry-pick-review
Issue that need cherry pick triage to approve
triaged
Issue has been triaged by sub team
Comments
lrhn
added
the
area-vm
|
lgtm |
|
@itsjustkevin is this a go ? |
itsjustkevin
added
the
cherry-pick-approved
|
@bkonyi go ahead and merge, this will land in the next release. |
copybara-service bot
pushed a commit
that referenced
this issue
Apr 12, 2024
…apshot The previous logic for building the path to dds.dart.snapshot would result in the Windows drive letter being dropped from the path: \path\to\dart-sdk\bin\dds.dart.snapshot This works most of the time since a leading slash is treated as a reference to the current drive, which often contains the Dart SDK. However, if the SDK is on a different drive than the current (e.g., in a container with two drives), the VM will fail to find the snapshot. This change uses the File(...) APIs from dart:io to build the path rather than trying to use the Uri class to manually hack together a path. TEST=N/A, not reproducible without a second Windows drive Bug: grpc/grpc-dart#697 Change-Id: I71d00b07a98508a780f5aab76417da4aa530f3c4 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/360920 Cherry-pick-request: #55386 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361400 Reviewed-by: Siva Annamalai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
d4c20e2
Target
Beta (should be included in upcoming stable)
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/361400
Issue Description
The VM service would fail to launch DDS when the SDK was on one Windows drive and the target program was executed in the context of a different drive. The logic to manually build the URI to the DDS snapshot resulted in Windows drive letters being omitted from the URI. This works fine for most cases since the path started with a leading
/, which is interpreted as the current drive, but fails if the SDK is not present on the current drive.What is the fix
Updates the
_DebuggingSessionlogic in the VM service responsible for launching DDS to use thedart:ioFileAPI to consistently get a well-formed path to SDKbindirectory rather than trying to manually build it usingUriAPIs.Why cherry-pick
Windows users with multiple drives may encounter crashes when enabling the VM service.
Risk
Low risk.
Issue link(s)
grpc/grpc-dart#697
Extra Info
No response
The text was updated successfully, but these errors were encountered: