Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider generating the external link icon statically. #1058

Closed
3 tasks
chalin opened this issue Aug 8, 2018 · 1 comment
Closed
3 tasks

Consider generating the external link icon statically. #1058

chalin opened this issue Aug 8, 2018 · 1 comment
Labels
co.help-wanted Community opportunity to help documentation e2-days Can complete in < 5 days of normal, not dedicated, work infra.design Relates to the design of docs.Dart.dev infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@chalin
Copy link
Contributor

chalin commented Aug 8, 2018

  • Generating the external link icon statically.
  • Add target="_blank" rel="noopener".
  • Handle punctuation correctly.
@chalin chalin added infra.structure Relates to the tools that create dart.dev infra.design Relates to the design of docs.Dart.dev labels Aug 8, 2018
@chalin chalin mentioned this issue Aug 8, 2018
Merged
@kwalrath kwalrath mentioned this issue Jan 31, 2019
Open
@kwalrath kwalrath added p2-medium Necessary but not urgent concern. Resolve when possible. co.help-wanted Community opportunity to help documentation e2-days Can complete in < 5 days of normal, not dedicated, work labels Jan 31, 2019
@kwalrath kwalrath mentioned this issue Jan 11, 2020
Merged
@parlough parlough mentioned this issue Aug 8, 2022
Closed
4 tasks
@parlough
Copy link
Member

parlough commented Aug 2, 2023

For now, this isn't a big enough deal. If we do switch tooling, we can consider it then.

@parlough parlough closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
co.help-wanted Community opportunity to help documentation e2-days Can complete in < 5 days of normal, not dedicated, work infra.design Relates to the design of docs.Dart.dev infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kwalrath @chalin @parlough