Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

futures codelab needs tests for examples #1810

Closed
legalcodes opened this issue Aug 3, 2019 · 10 comments
Closed

futures codelab needs tests for examples #1810

legalcodes opened this issue Aug 3, 2019 · 10 comments
Labels
a.tut.codelab-google Relates to codelabs hosted on codelabs.developers.google.com e2-days Can complete in < 5 days of normal, not dedicated, work fix.bug Needs fix of incorrect copy, code, or visual from.study Reported in a UX study infra.dartpad Relates to DartPad component code or functionality p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@legalcodes
Copy link
Contributor

legalcodes commented Aug 3, 2019

(1) We should write tests for the test code that runs in DartPad exercises
(2) We should extract / test the code in example snippets.

Ed 10/23: We should update the codelab's test code to use Andrew's test package. (The test code was written before the package was finished.)

@legalcodes legalcodes added fix.bug Needs fix of incorrect copy, code, or visual e2-days Can complete in < 5 days of normal, not dedicated, work labels Aug 3, 2019
@legalcodes legalcodes self-assigned this Aug 3, 2019
@legalcodes legalcodes added the p2-medium Necessary but not urgent concern. Resolve when possible. label Aug 3, 2019
@legalcodes legalcodes mentioned this issue Aug 3, 2019
4 tasks
@galeyang galeyang added the from.study Reported in a UX study label Sep 3, 2019
@galeyang
Copy link
Contributor

galeyang commented Sep 4, 2019

Details from previous offline discussion

We need tests for test code: 1. ensure solution code works 2. feed failing code and check out test result and custom error messages

cc: @RedBrogdon I'm not sure which repo should we use to track this.

@legalcodes
Copy link
Contributor Author

legalcodes commented Sep 4, 2019

@galeyang Sorry, I should have clarified in the initial description:

(1) should probably be tracked in dart-lang/dart-pad @RedBrogdon please correct if I'm mistaken about this
(2) can be tracked in dart-lang/site-www (this issue) since we currently have a mechanism for doing this repo

@kwalrath
Copy link
Contributor

kwalrath commented Sep 5, 2019

If we could get the DartPads' code from arbitrary repo files, not just gists, then (2) could possibly take care of (1) for this site.

@kwalrath kwalrath added the infra.dartpad Relates to DartPad component code or functionality label Sep 5, 2019
@kwalrath kwalrath added the a.tut.codelab-google Relates to codelabs hosted on codelabs.developers.google.com label Oct 23, 2019
@kwalrath
Copy link
Contributor

@legalcodes could you update the status of this?

@legalcodes
Copy link
Contributor Author

AFAIK we can't move forward on this before flutter/website#3262 is resolved, though to be 100% certain we'd need to verify that the issue exists for dart-lang/site-www.

@kwalrath
Copy link
Contributor

Looks like flutter/website#3262 has been resolved.

@legalcodes
Copy link
Contributor Author

This codelab uses gists, so IIRC in order to add testing we're also waiting for an update on dart-lang/dart-pad#1120.

@RedBrogdon can you please advise?

@kwalrath
Copy link
Contributor

#2454 changed the codelab to use embedded code, rather than gists. So now the code is analyzed, but the tests still aren't being automatically run.

@parlough
Copy link
Member

parlough commented Nov 7, 2022

I'm going to close this in favor of #1803 now that the page is using code excerpts, we just need to actually hook up the tests to run.

@parlough parlough closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.tut.codelab-google Relates to codelabs hosted on codelabs.developers.google.com e2-days Can complete in < 5 days of normal, not dedicated, work fix.bug Needs fix of incorrect copy, code, or visual from.study Reported in a UX study infra.dartpad Relates to DartPad component code or functionality p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Development

No branches or pull requests

4 participants