-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
futures codelab needs tests for examples #1810
Comments
Details from previous offline discussion
cc: @RedBrogdon I'm not sure which repo should we use to track this. |
@galeyang Sorry, I should have clarified in the initial description: (1) should probably be tracked in dart-lang/dart-pad @RedBrogdon please correct if I'm mistaken about this |
If we could get the DartPads' code from arbitrary repo files, not just gists, then (2) could possibly take care of (1) for this site. |
@legalcodes could you update the status of this? |
AFAIK we can't move forward on this before flutter/website#3262 is resolved, though to be 100% certain we'd need to verify that the issue exists for dart-lang/site-www. |
Looks like flutter/website#3262 has been resolved. |
This codelab uses gists, so IIRC in order to add testing we're also waiting for an update on dart-lang/dart-pad#1120. @RedBrogdon can you please advise? |
#2454 changed the codelab to use embedded code, rather than gists. So now the code is analyzed, but the tests still aren't being automatically run. |
I'm going to close this in favor of #1803 now that the page is using code excerpts, we just need to actually hook up the tests to run. |
(1) We should write tests for the test code that runs in DartPad exercises
(2) We should extract / test the code in example snippets.
Ed 10/23: We should update the codelab's test code to use Andrew's test package. (The test code was written before the package was finished.)
The text was updated successfully, but these errors were encountered: