Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address TODO related to running browser tests #2860

Closed
1 of 2 tasks
woinbo opened this issue Jan 14, 2021 · 2 comments
Closed
1 of 2 tasks

Address TODO related to running browser tests #2860

woinbo opened this issue Jan 14, 2021 · 2 comments
Assignees
@parlough
Labels
e1-hours Can complete in < 8 hours of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@woinbo
Copy link
Contributor

woinbo commented Jan 14, 2021 •
edited by parlough
Loading

TODO's related to analyzing Dart code in the repo:

  • TODO After dart CLI ships in stable, use dart analyze for all channels. link to file (fixed by 1510195)

  • TODO(chalin): as of 2019/11/17, we don't need to select individual browser test files. Run browser tests over all files, since VM-only tests have been annotated as such.
    link to file

@kwalrath (#2119 )
@woinbo woinbo mentioned this issue Jan 14, 2021
Closed
15 tasks
@kwalrath kwalrath added e1-hours Can complete in < 8 hours of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible. labels Jan 14, 2021
@kwalrath kwalrath changed the title Fix issues related to Dart analyze Fix issues related to analyzing Dart code in the repo Jan 14, 2021
@kwalrath kwalrath changed the title Fix issues related to analyzing Dart code in the repo Address TODOs related to analyzing Dart code in the repo Jan 14, 2021
@parlough parlough changed the title Address TODOs related to analyzing Dart code in the repo Address TODO related to running browser tests Jul 15, 2021
@parlough
Copy link
Member

I've updated this as the first TODO was fixed and removed by 1510195

The remaining issue/TODO still exists.

@parlough
Copy link
Member

parlough commented Aug 2, 2023

The site and how the tests are ran has gone through a complete rearchitecture since this issue was made, so I'm going to close this. If anyone would still like to see further improvements, please open a new individual issue. Thanks so much!

@parlough parlough closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
e1-hours Can complete in < 8 hours of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kwalrath @parlough @woinbo