Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify library documentation around support for deferred loading in AOT mode #5100

Closed
a-siva opened this issue Aug 10, 2023 · 3 comments · Fixed by #5489
Closed

Clarify library documentation around support for deferred loading in AOT mode #5100

a-siva opened this issue Aug 10, 2023 · 3 comments · Fixed by #5489
Assignees
@atsansone
Labels
a.language Relates to the Dart language tour e1-hours Can complete in < 8 hours of normal, not dedicated, work p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged

Comments

@a-siva
Copy link

a-siva commented Aug 10, 2023

https://dart.dev/language/libraries states that deferred loading is not supported in the Flutter and Dart VM.
This is not entirely true, we do support deferred loading in AOT mode, this text needs to be updated to reflect
the current state.

Please see dart-lang/sdk#33118 which was closed as implemented for AOT
@parlough
Copy link
Member

Thanks for the issue. Could you move this to dart-lang/site-www? Otherwise it will get lost.

Are there any special concerns for deferred loading in AOT that we should make sure to mention?

@a-siva a-siva transferred this issue from dart-lang/sdk Aug 10, 2023
@a-siva
Copy link
Author

a-siva commented Aug 10, 2023

Thanks for the issue. Could you move this to dart-lang/site-www? Otherwise it will get lost.

Done

Are there any special concerns for deferred loading in AOT that we should make sure to mention?

Please see doc

@danagbemava-nc danagbemava-nc added st.triage.triage-team Triage team reviewing and categorizing the issue a.language Relates to the Dart language tour p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Can complete in < 8 hours of normal, not dedicated, work and removed st.triage.triage-team Triage team reviewing and categorizing the issue labels Aug 11, 2023
@atsansone atsansone changed the title Documentation claims deferred loading is not supported in the VM (we do support it in AOT mode) Clarify library documentation around support for deferred loading in AOT mode Aug 21, 2023
@atsansone atsansone added the st.triage.ltw Indicates Lead Tech Writer has triaged label Aug 21, 2023
@MaryaBelanger MaryaBelanger self-assigned this Aug 21, 2023
@atsansone
Copy link
Contributor

Per this comment, the Lazily loading a library needs an update.

@atsansone atsansone assigned atsansone and unassigned MaryaBelanger Jan 26, 2024
@atsansone atsansone mentioned this issue Jan 26, 2024
Merged
atsansone added a commit that referenced this issue Mar 22, 2024
@atsansone
Updated deferred language (#5489)
dd2ac46 
Fixes #5100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atsansone atsansone

Labels
a.language Relates to the Dart language tour e1-hours Can complete in < 8 hours of normal, not dedicated, work p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated deferred language atsansone/site-www
5 participants
@atsansone @a-siva @parlough @danagbemava-nc @MaryaBelanger