Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe conditional imports on the 'Libraries' page #5109

Closed
Nashev opened this issue Aug 14, 2023 · 3 comments
Closed

Describe conditional imports on the 'Libraries' page #5109

Nashev opened this issue Aug 14, 2023 · 3 comments
Assignees
Labels
a.libraries Relating to the Dart standard libraries. cl.duplicate Closes issue as duplicate of another issue e1-hours Can complete in < 8 hours of normal, not dedicated, work from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged

Comments

@Nashev
Copy link

Nashev commented Aug 14, 2023

Page URL

https://dart.dev/language/libraries.html

Page source

https://github.com/dart-lang/site-www/tree/main/src/language/libraries.md

Describe the problem

There is not described syntax like
import 'html_stub.dart' if (dart.library.html) 'dart:html' as html;
but i see the source code used it. It must be described there.

P.S. What dart.library.html is here?

Expected fix

Move or copy this section into the https://github.com/dart-lang/site-www/tree/main/src/language/libraries.md page and a little rewrite to more consistency. With a link to specification of the dart.library.

Additional context

No response

@Nashev
Copy link
Author

Nashev commented Aug 14, 2023

Also there must be link to the https://dart.dev/guides/libraries page for clarification what names can be used in the if part

@danagbemava-nc danagbemava-nc added st.triage.triage-team Triage team reviewing and categorizing the issue a.libraries Relating to the Dart standard libraries. p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Can complete in < 8 hours of normal, not dedicated, work and removed st.triage.triage-team Triage team reviewing and categorizing the issue labels Aug 14, 2023
@atsansone atsansone added the from.page-issue Reported in a reader-filed concern label Aug 21, 2023
@atsansone atsansone changed the title [PAGE ISSUE]: 'Libraries Describe conditional imports on the 'Libraries' page Aug 21, 2023
@atsansone atsansone added the st.triage.ltw Indicates Lead Tech Writer has triaged label Aug 21, 2023
@atsansone
Copy link
Contributor

@munificent : Would you have something I could reference to write out this documentation?

@atsansone atsansone assigned atsansone and unassigned munificent Aug 21, 2023
@parlough
Copy link
Member

Thanks for raising this! It's definitely an area we need to work on documenting better soon. We're also open to contributions!

Closing in favor of #4225 which also tracks this work.

Thanks again :)

@parlough parlough closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
@danagbemava-nc danagbemava-nc added the cl.duplicate Closes issue as duplicate of another issue label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.libraries Relating to the Dart standard libraries. cl.duplicate Closes issue as duplicate of another issue e1-hours Can complete in < 8 hours of normal, not dedicated, work from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged
Projects
None yet
Development

No branches or pull requests

5 participants