Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add website staging GCB template #5418

Merged
merged 16 commits into from
Dec 22, 2023
Merged

Add website staging GCB template #5418

merged 16 commits into from
Dec 22, 2023

Conversation

drewroengoogle
Copy link
Contributor

@drewroengoogle drewroengoogle commented Dec 19, 2023 •
edited
Loading

  • Adds a GCB template that is responsible for building the website and staging it to firebase in PRs
  • Once the website is built, dart-github-bot will comment in the PR a link that you can navigate to in order to see your changes.
  • After this template is merged in, we can update the PR trigger to run this template on all PRs. It is currently disabled in order to ensure that it is not run on branches without this template in it yet.
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn’t contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

@drewroengoogle drewroengoogle changed the base branch from main to wip-test-branch December 19, 2023 21:21
@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 6dbd0bc):

https://dart-dev--pr5418-staging-gksk93oy.web.app

@drewroengoogle drewroengoogle changed the base branch from wip-test-branch to main December 19, 2023 21:48
@drewroengoogle drewroengoogle changed the title WIP: Add staging GCB template Add website staging GCB template Dec 19, 2023
@drewroengoogle
Copy link
Contributor Author

@parlough This is the same as the change made to the flutter docs site!

@parlough parlough self-assigned this Dec 20, 2023
@parlough
Copy link
Member

parlough commented Dec 20, 2023 •
edited
Loading

Thanks so much for working on this @drewroengoogle! Will be nice to get in. I'll take a look tomorrow.

There is one blocking issue though...

You need to give @dart-github-bot a proper icon! Something Dart or Dash related. I bet @khanhnwin has a big collection if you don't have anything in mind. 😄

@drewroengoogle
Copy link
Contributor Author

drewroengoogle commented Dec 21, 2023 •
edited
Loading

Thanks so much for working on this @drewroengoogle! Will be nice to get in. I'll take a look tomorrow.

There is one blocking issue though...

You need to give @dart-github-bot a proper icon! Something Dart or Dash related. I bet @khanhnwin has a big collection if you don't have anything in mind. 😄

Khanh helped find a couple shiny new profile photos for the dart and flutter bots that have now been added!

@khanhnwin
Copy link
Contributor

@parlough you know me too well haha Always happy to provide cute graphics :)

parlough
parlough approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!!

@parlough parlough merged commit 9ceae6f into dart-lang:main Dec 22, 2023
8 checks passed
@drewroengoogle drewroengoogle deleted the staging branch January 2, 2024 17:04
@drewroengoogle drewroengoogle mentioned this pull request Jan 2, 2024
Closed
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
@drewroengoogle @atsansone
Add website staging GCB template (dart-lang#5418)
c3b6ffe 
* Adds a GCB template that is responsible for building the website and
staging it to firebase in PRs
* Once the website is built, `dart-github-bot` will comment in the PR a
link that you can navigate to in order to see your changes.
* After this template is merged in, we can update the PR trigger to run
this template on all PRs. It is currently disabled in order to ensure
that it is not run on branches without this template in it yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@khanhnwin khanhnwin khanhnwin approved these changes

Assignees

@parlough parlough

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drewroengoogle @dart-github-bot @parlough @khanhnwin