Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible false positive attribute with namespace "serif:id" #113

Open
Orgoth opened this issue Jan 22, 2025 · 0 comments
Open

possible false positive attribute with namespace "serif:id" #113

Orgoth opened this issue Jan 22, 2025 · 0 comments

Comments

@Orgoth
Copy link
Contributor

Orgoth commented Jan 22, 2025

@darylldoyle

Do you see a security problem in the observance of namespaces for attributes?

e.g.: serif:id="Page 1”

<g id="Page-1" serif:id="Page 1">

In my opinion, this should not trigger a “Suspicious attribute ‘serif:id’” message, as the “id” attribute is already on the whitelist.

https://github.com/darylldoyle/svg-sanitizer/blob/master/src/data/AllowedAttributes.php#L56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant