From 52d32761f82af55689c2914bcdcf6cd5a48af259 Mon Sep 17 00:00:00 2001 From: Andrea Leopardi Date: Wed, 4 Dec 2024 16:00:58 +0700 Subject: [PATCH] Rename the "Ets" config storage to "ETS" (#346) --- lib/broadway/config_storage.ex | 6 ++---- lib/broadway/config_storage/ets.ex | 2 +- test/broadway/config_storage_test.exs | 21 ++++++++++++--------- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/lib/broadway/config_storage.ex b/lib/broadway/config_storage.ex index 5d4a299..b82b3df 100644 --- a/lib/broadway/config_storage.ex +++ b/lib/broadway/config_storage.ex @@ -1,8 +1,6 @@ defmodule Broadway.ConfigStorage do @moduledoc false - alias Broadway.ConfigStorage.{Ets, PersistentTerm} - @doc """ Optional setup for the configuration storage """ @@ -36,8 +34,8 @@ defmodule Broadway.ConfigStorage do @spec get_module() :: module() def get_module() do case Application.fetch_env!(:broadway, :config_storage) do - :ets -> Ets - :persistent_term -> PersistentTerm + :ets -> Broadway.ConfigStorage.ETS + :persistent_term -> Broadway.ConfigStorage.PersistentTerm mod -> mod end end diff --git a/lib/broadway/config_storage/ets.ex b/lib/broadway/config_storage/ets.ex index 3dc7a6e..9d1d002 100644 --- a/lib/broadway/config_storage/ets.ex +++ b/lib/broadway/config_storage/ets.ex @@ -1,4 +1,4 @@ -defmodule Broadway.ConfigStorage.Ets do +defmodule Broadway.ConfigStorage.ETS do @moduledoc false @behaviour Broadway.ConfigStorage diff --git a/test/broadway/config_storage_test.exs b/test/broadway/config_storage_test.exs index e77f00d..57fbe0f 100644 --- a/test/broadway/config_storage_test.exs +++ b/test/broadway/config_storage_test.exs @@ -1,6 +1,7 @@ defmodule Broadway.ConfigStorageTest do use ExUnit.Case, async: false - alias Broadway.ConfigStorage.Ets + + alias Broadway.ConfigStorage.ETS setup do prev = Application.fetch_env!(:broadway, :config_storage) @@ -12,13 +13,15 @@ defmodule Broadway.ConfigStorageTest do test "ets default options" do Application.put_env(:broadway, :config_storage, :ets) - Ets.setup() - assert [] = Ets.list() - assert Ets.put("some name", %Broadway.Topology{}) - assert ["some name"] = Ets.list() - assert %Broadway.Topology{} = Ets.get("some name") - assert :ets.info(Ets.table(), :size) == 1 - Ets.delete("some name") - assert :ets.info(Ets.table(), :size) == 0 + ETS.setup() + assert [] = ETS.list() + + assert ETS.put("some name", %Broadway.Topology{}) + assert ["some name"] = ETS.list() + assert %Broadway.Topology{} = ETS.get("some name") + assert :ets.info(ETS.table(), :size) == 1 + + ETS.delete("some name") + assert :ets.info(ETS.table(), :size) == 0 end end