From 883d9e0be19c5840c2491a404764a1cd1c82e77c Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Mon, 11 Apr 2022 11:04:17 +0200 Subject: [PATCH] Merge bitcoin/bitcoin#24797: test: compare `/chaininfo` response with `getblockchaininfo` RPC 0f7dc893ea1776515173dcd0bfe6826e963c90f3 test: compare `/chaininfo` response with `getblockchaininfo` RPC (brunoerg) Pull request description: The `/chaininfo` REST endpoint gets its infos from `getblockchaininfo` RPC, so this PR adds an `assert_equal` (in `interface_rest`) to ensure both responses are the same. Obs: other endpoints do the same for their respective RPC. ACKs for top commit: 0xB10C: Concept and Code Review ACK 0f7dc893ea1776515173dcd0bfe6826e963c90f3. Belts-and-spenders. Tree-SHA512: 51cbcf988090272e406a47dc869710740b74e2222af29c05ddcbf53bd49765cdc59efb525e970867f091b3d2efec4fb13371a342d9e484e51144b760265bc5b8 --- test/functional/interface_rest.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/functional/interface_rest.py b/test/functional/interface_rest.py index 6c6341f5479aa4..5ccd31957a75ac 100755 --- a/test/functional/interface_rest.py +++ b/test/functional/interface_rest.py @@ -342,5 +342,9 @@ def run_test(self): json_obj = self.test_rest_request("/chaininfo") assert_equal(json_obj['bestblockhash'], bb_hash) + # Compare with normal RPC getblockchaininfo response + blockchain_info = self.nodes[0].getblockchaininfo() + assert_equal(blockchain_info, json_obj) + if __name__ == '__main__': RESTTest().main()