Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting generateName in DaskJob resources #896

Open
msyulia opened this issue Jun 25, 2024 · 1 comment
Open

Allow setting generateName in DaskJob resources #896

msyulia opened this issue Jun 25, 2024 · 1 comment

Comments

@msyulia
Copy link

msyulia commented Jun 25, 2024

What?

Setting metadata.generateName in kubernetes jobs (batch/v1 Job) allows to re-run jobs after applying the resource again without the need to delete the previous job [source].
Currently trying to set this field on a DaskJob resource results in missing metadata.name in object {kubernetes.dask.org/v1 DaskJob}

Why?

Having the name be randomised via generateName on a DaskJob resource would allow users to rerun those jobs without the need to delete the completed jobs.
In my use case I would like to deploy DaskJobs using ArgoCD as the k8s controller, generating the name on the fly would allow to rerun the job whenever a sync is triggered.

How?

Following the ObjectMeta spec:

apiVersion: kubernetes.dask.org/v1
kind: DaskJob
metadata:
    generateName: dask-hello-world-

Imo I don't see a reason to implement this feature in the python library, but maybe someone will prove me wrong 😄

As a sidenote, I'd be happy to work on this if determined to be useful.

@jacobtomlinson
Copy link
Member

This sounds like a great improvement. If you're happy to work on this that would be awesome.

I agree that we probably don't need to worry about the Python client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants