-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative path is not working within artifacts #1927
Labels
Comments
Thanks for reporting. Working on a repro. |
This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
This was referenced Jan 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 14, 2025
## Changes We perform a check during path translation that the path being referenced is contained in the bundle's sync root. If it isn't, it's not a valid remote reference. However, this doesn't apply to paths that are _always_ local, such as the artifact path. An artifact's build command is executed in its path. Files created by the artifact build (e.g. wheels or JARs) don't need to be in the sync root because they have a dedicated and different upload path into `${workspace.artifact_path}`. Therefore, this check that a path is contained in the bundle's sync root doesn't apply to artifact paths. This change modifies the structure of path translation to allow opting out of this check. Fixes #1927. ## Tests * Existing and new tests pass. * Manually confirmed that building and using a wheel built outside the sync root path works as expected. * No acceptance tests because we don't run build as part of validate.
@jiropardo The fix for this has been released as part of v0.239.0. Can you confirm it resolves the issue for you? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue
Trying to deploy an artifcat referencing a location from an upstream folder when building an artifact using Relative path fails with a path resoultion error
Configuration
Please provide a minimal reproducible configuration for the issue
Steps to reproduce the behavior
Please list the steps required to reproduce the issue, for example:
1 Init a bundle , select python template , include python packae
├── lib
│ ├── setup.py
│ └── src
├── cus_test
│ │
│ └── test_x
│ │
│ ├── setup.py
│ └── src
│ │
│ ├── databricks.yml
databricks.yml file
If I use absolute path in the artifacts path, it works with no issues
Expected Behavior
Path error should have not come up and they deployment should end up successfully
Actual Behavior
Clear and concise description of what actually happened
It give a path resolution error
OS and CLI version
Please provide the version of the CLI (eg: v0.1.2) and the operating system (eg: windows). You can run databricks --version to get the version of your Databricks CLI
Databricks CLI v0.234.0
Is this a regression?
Did this work in a previous version of the CLI? If so, which versions did you try? Never worked, not even in pre release CLI
Debug Logs
Output logs if you run the command with debug logs enabled. Example: databricks bundle deploy --log-level=debug. Redact if needed
Building default...
09:59:10 ERROR Error: build failed default, error: chdir /Users/admin/Documents/tests/bundle/path_resolution/cus_test/test_x/cus_test/test_x: no such file or directory, output: pid=59588 mutator=seq mutator=build mutator=seq mutator=artifacts.BuildAll mutator=seq mutator=artifacts.Build(default) mutator=seq mutator=artifacts.whl.Build(default)
The text was updated successfully, but these errors were encountered: