Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Only create admin SP if SAT is being used #89

Closed
JDBraun opened this issue Sep 4, 2024 · 2 comments
Closed

[AWS] Only create admin SP if SAT is being used #89

JDBraun opened this issue Sep 4, 2024 · 2 comments
Assignees
Labels
remove A feature to remove

Comments

@JDBraun
Copy link
Contributor

JDBraun commented Sep 4, 2024

Can remove the admin SP from normal workflows, since it isn't complex code to add-on. In addition, since an SP is now enforced for TF, and not basic auth, the user would know how to do so manually in a worst case scenario

@jdbraun-db jdbraun-db self-assigned this Sep 5, 2024
@jdbraun-db jdbraun-db added the remove A feature to remove label Sep 5, 2024
@JDBraun
Copy link
Contributor Author

JDBraun commented Sep 9, 2024

decided to use the same SP that is being used for the OAuth to keep one ownership across the board

@jdbraun-db
Copy link
Contributor

updated with #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remove A feature to remove
Projects
None yet
Development

No branches or pull requests

2 participants