Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db_volume_delete bad type #73

Closed
vladimirobucina opened this issue Dec 4, 2024 · 2 comments · Fixed by #74
Closed

db_volume_delete bad type #73

vladimirobucina opened this issue Dec 4, 2024 · 2 comments · Fixed by #74
Assignees
@vladimirobucina @zacdav-db
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@vladimirobucina
Copy link
Contributor

There is an error on this line:

brickster/R/volume-fs.R

Line 46 in c032a87

type = "directories",

Should be changed to files instead of directories.
@zacdav-db zacdav-db added bug Something isn't working good first issue Good for newcomers labels Dec 9, 2024
@zacdav-db
Copy link
Collaborator

Good pickup! Would you mind making a simple PR and I can merge?

@vladimirobucina
Copy link
Contributor Author

Yes, I'll fork the repo, and make a PR :)

vladimirobucina pushed a commit to vladimirobucina/brickster that referenced this issue Dec 12, 2024
fixes databrickslabs#73: Fix db_volume_delete() function, by changi…
7521750 
…ng type of `db_volume_action()` call to files.
@vladimirobucina vladimirobucina mentioned this issue Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladimirobucina vladimirobucina

@zacdav-db zacdav-db

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: db_volume_delete vladimirobucina/brickster
2 participants
@vladimirobucina @zacdav-db