Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope relevant groups using include_group_ids #3719

Open
1 task done
JCZuurmond opened this issue Feb 19, 2025 · 0 comments
Open
1 task done

Scope relevant groups using include_group_ids #3719

JCZuurmond opened this issue Feb 19, 2025 · 0 comments
Labels
migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade needs-triage

Comments

@JCZuurmond
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

The group migration integration tests are a common culprit for failing sporadically because accounts groups pile up over time causing tests to timeout due to longer running API calls (e.g. #3706 and #3702).

Proposed Solution

Scope relevant groups using include_group_ids in the GroupsCrawler and dependent object so that we do not need to list all account groups in the integration tests bu that we limit the calls to GET for the include_group_ids

Additional Context

A include_group_names parameter already exists, which should be kept for backwards compatibility of the config file. We need the group ids to switch from LIST to GET calls.

Also #3718 requests for a clean up of the account groups

@JCZuurmond JCZuurmond added this to UCX Feb 19, 2025
@github-project-automation github-project-automation bot moved this to Todo in UCX Feb 19, 2025
@JCZuurmond JCZuurmond added the migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade needs-triage
Projects
Status: Todo
Development

No branches or pull requests

1 participant