Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_function: way to test if arguments are NOT specified #271

Open
filipsch opened this issue Jun 8, 2018 · 0 comments
Open

check_function: way to test if arguments are NOT specified #271

filipsch opened this issue Jun 8, 2018 · 0 comments

Comments

@filipsch
Copy link
Contributor

filipsch commented Jun 8, 2018

With check_function() and check_args(), it is possible whether some arguments are specified, and whether they are correct (with has_equal_ast()), but it is not possible to check if some arguments are not specified. There is test_not() functionality, but this will not work in the current implementation: if certain arguments are not found in the solution, an exception is thrown and the SCT execution errors out.

To improve this, we could adopt a TestFailSolution exception, that is thrown every time we're trying to access e.g. an argument that is also not in the solution. This error is actually thrown if we're not in test_not() mode (the SCT was incorrectly written), and that is swallowed if we are in test_not() mode (the SCT did this on purpose).

cc @yashasroy

@filipsch filipsch self-assigned this Jun 8, 2018
@filipsch filipsch removed their assignment Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant