Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra: Ensure analysis payload is set to None when facing an analysis error #137

Open
maudetes opened this issue Aug 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@maudetes
Copy link
Contributor

When we encounter a "File too large to download" on analysis, we only send the payload with analysis:error to udata and don't remove previous keys that may become irrelevant (analysis:checksum, analysis:last-modified-at etc.).

Indeed, extras update in udata has a dict update policy and a strip of keys with None value.

We should make sure to remove other analysis keys when facing an error by adding them in payload with None value.
Indeed, when a file has been analyzed but is now bigger than the limit, previous extras will be kept forever in udata.

On the contrary, on a successful analysis, we should make sure to remove eventual existing analysis:error by setting to None.

@maudetes maudetes added the bug Something isn't working label Aug 21, 2024
@maudetes maudetes changed the title Ensure analysis payload is set to None when facing an analysis error hydra: Ensure analysis payload is set to None when facing an analysis error Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📝 Todo
Development

No branches or pull requests

1 participant