Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Should app.js be in version control? #36

Open
morty opened this issue Oct 25, 2015 · 1 comment
Open

Should app.js be in version control? #36

morty opened this issue Oct 25, 2015 · 1 comment

Comments

@morty
Copy link
Contributor

morty commented Oct 25, 2015

It seems to be a compiled resource which would suggest it should not be in version control.

@rossjones
Copy link
Contributor

Yes and no. Normally all the JS in web/static/js is compiled to priv/static/app.js (as ES6), and the rest in web/static/vendor (ES <6) into vendor.js - we probably shouldn't have priv/ in git at all. This only happens in MIX_ENV=dev though, not when MIX_ENV=prod. We're running this way as we're not doing proper releases yet, we're just pulling from git on prod.

When we implement exrm we can move to just building properly and it'll end up in the .tgz release so we won't need priv.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants