Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timezone underspecified #12

Open
bendichter opened this issue Dec 14, 2021 · 2 comments
Open

timezone underspecified #12

bendichter opened this issue Dec 14, 2021 · 2 comments
Labels

Comments

@bendichter
Copy link
Contributor

bendichter commented Dec 14, 2021

lab.Lab currently has a timezone field that has values such as “UTC+0”. I don’t think this is going to work for many locations, because the UTC offset of timezones can change throughout the year based on daylight savings time.

Better would be to choose from a list of named timezones such as pytz.common_timezones:

['Africa/Abidjan', 'Africa/Accra', 'Africa/Addis_Ababa', 'Africa/Algiers', 'Africa/Asmara', 'Africa/Bamako', 'Africa/Bangui', 'Africa/Banjul', 'Africa/Bissau', 'Africa/Blantyre', 'Africa/Brazzaville', 'Africa/Bujumbura', 'Africa/Cairo', 'Africa/Casablanca', 'Africa/Ceuta', 'Africa/Conakry', 'Africa/Dakar', 'Africa/Dar_es_Salaam', 'Africa/Djibouti', ...

better still would be to find an international standard for timezones. Maybe pytz follows one, I'm not sure.

@bendichter
Copy link
Contributor Author

Also, timezone should probably be under Location

@bendichter
Copy link
Contributor Author

@kabilar can you take a look at this?

@kabilar kabilar added this to the NIH U24 Year 2 milestone Dec 20, 2021
@CBroz1 CBroz1 added the NWB label May 6, 2022
@CBroz1 CBroz1 removed this from the Year 2 milestone May 6, 2022
@CBroz1 CBroz1 self-assigned this Jun 15, 2022
@kabilar kabilar added this to the 2023Q2+ milestone Jul 1, 2022
@kabilar kabilar removed this from the 2023Q2+ milestone Jan 2, 2023
@CBroz1 CBroz1 removed their assignment Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants