Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing the labels format #33

Open
vpavlin opened this issue Aug 31, 2020 · 1 comment
Open

Consider changing the labels format #33

vpavlin opened this issue Aug 31, 2020 · 1 comment
Assignees
@YiannisGkoufas
Labels
enhancement New feature or request

Comments

@vpavlin
Copy link

vpavlin commented Aug 31, 2020

The current label format does not follow the best practices I have been seeing around (https://github.com/IBM/dataset-lifecycle-framework/blob/master/examples/hive/sampleapp/samplepod.yaml#L8)

Have you considered prefixing your labels similarly to https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
@YiannisGkoufas
Copy link
Collaborator

Definitely makes sense, thanks for bringing this up!

@YiannisGkoufas YiannisGkoufas self-assigned this Sep 1, 2020
@srikumar003 srikumar003 added enhancement New feature or request and removed improvement labels Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YiannisGkoufas YiannisGkoufas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srikumar003 @vpavlin @YiannisGkoufas