Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset labels not working for deployments #88

Open
chazapis opened this issue Mar 11, 2021 · 3 comments
Open

Dataset labels not working for deployments #88

chazapis opened this issue Mar 11, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@chazapis
Copy link
Contributor

When I use a dataset label to mount a dataset to a deployment, nothing happens.

Upon further inspection, it looks like the MutatingWebhookConfiguration does not trigger for deployments, but only for pods. For deployments, the mutate function should do exactly the same changes it does for pods, but work on the /spec/template/spec path instead of /spec.

@pkoutsov pkoutsov added the enhancement New feature or request label Aug 16, 2021
@SoulKyu
Copy link

SoulKyu commented Oct 27, 2021

Hi, having the same issue, could be cool if datashim could support deployement !

@5cat
Copy link

5cat commented Feb 8, 2023

I have the same issue,

I used PVC instead of labels although it is not recommended, it is what is working for deployments.

@ilvez
Copy link

ilvez commented Apr 4, 2023

I don't know about this, for me it worked (only relevant code of deployment description):

apiVersion: apps/v1
kind: Deployment
spec:
  template:
    metadata:
      labels:
        dataset.0.id: "example-dataset"
        dataset.0.useas: "mount"

Tested it first out with pod as an example, and then added dataset labels into deployment description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants